Skip to content

[CodeQuality] Skip session_set_save_handler in AddNameToBooleanArgumentRector - #8750

Merged
TomasVotruba merged 2 commits into
mainfrom
fix-9936-session-set-save-handler-named-arg
Oct 21, 2026
Merged

TomasVotruba merged 2 commits into
mainfrom
fix-9936-session-set-save-handler-named-arg

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Fixes rectorphp/rector#9936

session_set_save_handler has an alternate signature, so PHPStan reflection reports it as named-argument capable. At runtime PHP rejects named arguments on it (Unknown named parameter $register_shutdown).

\session_set_save_handler(new \App\Session(), true);
// was wrongly rewritten to:
\session_set_save_handler(new \App\Session(), register_shutdown: true);

Skip the function by name in the shared CallLikeArgumentNameAdder, so both AddNameToBooleanArgumentRector and AddNameToNullArgumentRector are covered.

@TomasVotruba
TomasVotruba merged commit 8c036b8 into main Oct 21, 2026
49 checks passed
@TomasVotruba
TomasVotruba deleted the fix-9936-session-set-save-handler-named-arg branch October 21, 2026 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Named arguments and session_set_save_handler

2 participants