Repository navigation
[CodeQuality] Deprecate CompleteDynamicPropertiesRector - #8753
Merged
Merged
Conversation
The rule can create invalid properties on classes with partial type information, better handled by adding typed properties by hand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rule guesses property types from assignments and can emit invalid properties on classes with only partial type information - e.g. when a parent or trait already declares the property under conditions Rector cannot see.
Adding missing properties by hand with correct types is safer, so the rule is deprecated:
CompleteDynamicPropertiesRectornow implementsDeprecatedInterface, body throwsCodeQualityLevelLocalPropertyAnalyzer,MissingPropertiesResolver,MissingPropertiesFactory,ClassLikeAnalyzer,ArrayDimFetchTypeResolver,PropertyTypeDecorator,DefinedPropertyWithType), and trimmed the unusedhasClassContextProperty()fromPropertyPresenceChecker