Repository navigation
[DeadCode] Compare switch case stmts node-by-node in RemoveDuplicatedCaseInSwitchRector - #8754
Merged
Merged
Conversation
…CaseInSwitchRector Compare the two case stmt lists by length then element-wise via areNodesEqual, instead of passing the arrays to the array overload. Avoids printing the whole statement lists and no longer depends on that overload.
TomasVotruba
force-pushed
the
fix-remove-duplicated-case-array-compare
branch
from
October 21, 2026 21:22
486ae08 to
527552a
Compare
TomasVotruba
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoveDuplicatedCaseInSwitchRectorcompared two case statement lists by passing thestmtsarrays straight intoNodeComparator::areNodesEqual(), relying on itsarrayoverload.Compare them by length and then node-by-node via
areNodesEqual(Node, Node)instead. This avoids printing the whole statement lists, benefits from the per-node class short-circuit, and no longer depends on the array overload.