Repository navigation
[PHPStan] Add rule to hoist resolveClassReflection() above foreach in Rector rules - #8758
Merged
TomasVotruba merged 2 commits intoOct 21, 2026
Merged
Conversation
… Rector rules The refactored class reflection is identical for every loop iteration, so resolving it inside a foreach() in a Rector rule is wasted work. New rule flags it; applied the hoist to 3 existing rules.
TomasVotruba
deleted the
phpstan-no-resolve-class-reflection-in-foreach
branch
October 21, 2026 22:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside a Rector rule,
resolveClassReflection($node)returns the single refactored class, which is identical on every loop iteration. Calling it inside aforeach()is wasted work - it should be hoisted above the loop.This adds a custom PHPStan rule
NoResolveClassReflectionInForeachRulethat flags such calls. It is scoped to classes implementingRectorInterface, so legitimate per-iteration resolution elsewhere (e.g. resolving a different class per statement) is not touched.Applied the hoist to the 3 Rector rules it flagged:
RemoveUnusedPrivateClassConstantRectorPropertyTypeFromStrictSetterGetterRectorTypedPropertyFromAssignsRector