Skip to content

[Arguments] Deprecate RemoveMethodCallParamRector as too niche and generic - #8766

Merged
TomasVotruba merged 1 commit into
mainfrom
deprecate-remove-method-call-param
Oct 22, 2026
Merged

TomasVotruba merged 1 commit into
mainfrom
deprecate-remove-method-call-param

Conversation

@TomasVotruba

Copy link
Copy Markdown
Member

Removing a single positional method-call param by object type + method name is too generic: the object-type match fires on any caller with a same-named method, so it can strip arguments from unrelated calls and produce invalid code. Prefer a dedicated rule for the specific API change.

Deprecates the rule following the standard pattern:

  • implements DeprecatedInterface + @deprecated note, refactor() throws
  • removed test fixtures and the RemoveMethodCallParam value object (only this rule used it)
  • not registered in any set

@TomasVotruba
TomasVotruba enabled auto-merge (squash) October 22, 2026 09:52
@TomasVotruba
TomasVotruba disabled auto-merge October 22, 2026 09:54
@TomasVotruba
TomasVotruba merged commit 56d303c into main Oct 22, 2026
48 of 49 checks passed
@TomasVotruba
TomasVotruba deleted the deprecate-remove-method-call-param branch October 22, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant