Repository navigation
[Transform] Deprecate ConstFetchToClassConstFetchRector as niche and never used - #8771
Merged
TomasVotruba merged 2 commits intoOct 22, 2026
Merged
Conversation
TomasVotruba
deleted the
tv-deprecate-const-fetch-to-class-const-fetch
branch
October 22, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
ConstFetchToClassConstFetchRector.A global constant name can be reused across unrelated contexts and does not map cleanly to a single class constant, so this rule is too niche and was never used in practice. Use a custom rule scoped to the exact case instead.
Follows the same deprecation shape as #8767 and the
ScalarValueToConstFetchRectordeprecation: marks the class@deprecated+DeprecatedInterface, gutsrefactor()to throw, and drops the rule tests. The rule is configurable and registered in no set, so nothing else needs unregistering.