Repository navigation
[TypeDeclaration] Deprecate AddPropertyTypeDeclarationRector as too niche and never used, not part of any set - #8774
Merged
Conversation
…iche and never used, not part of any set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
AddPropertyTypeDeclarationRector, following the same path as the other recently deprecated niche rules.The rule adds a property type by configured parent-class/property pairs. It is in no set or level, so it only ever ran via an explicit
withRules()/withConfiguredRule(), and it is too niche to maintain generically - a custom rule for the exact project case is clearer and safer.Changes:
DeprecatedInterface+@deprecated, gutrefactor()to throwAddPropertyTypeDeclarationvalue object (@api) for existing configs