[alfredbez]

In SimplifyEmptyCheckOnEmptyArrayRector, refactor() invoked ScopeFetcher::fetch($node) immediately at the start for every BooleanNot and Empty_ node in the codebase. For boolean negations where the child expression is not empty(), and for empty() expressions whose argument is not a variable or property fetch, scope resolution was performed unnecessarily.

Reproducer

class Subject
{
    public function run(bool $flag): void
    {
        if (!$flag) {
            return;
        }

        if (empty(getValues())) {
            return;
        }
    }
}

Expected Behavior

SimplifyEmptyCheckOnEmptyArrayRector should perform cheap node checks and reject unsupported node shapes (such as BooleanNot without Empty_, or non-variable/property expressions) before fetching node scope.

[TomasVotruba]

LGTM, thanks 👍