Repository navigation
[TypeDeclarationDocblocks] Skip multilines per phpstan-* tag on MergePhpstanDocTagIntoNativeRector - #8823
Closed
samsonasik wants to merge 3 commits into
Closed
[TypeDeclarationDocblocks] Skip multilines per phpstan-* tag on MergePhpstanDocTagIntoNativeRector#8823samsonasik wants to merge 3 commits into
samsonasik wants to merge 3 commits into
Conversation
…PhpstanDocTagIntoNativeRector
Member
Author
|
@TomasVotruba ready 👍 |
Member
|
I think the change is correct. We should prefer it, even though it would require running a coding standard (that's standard here) to allign the spacing. |
Member
Author
|
@TomasVotruba the issue is not spacing, the new line, even on docblock itself without description, phpcs already crash. |
Member
|
Indeed, it should be handled by coding standard. |
Member
Author
|
Okay, I created PR to phpcs then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
phpcs not support multiline per param/var/return docblock, see
Squiz.Commenting.FunctionComment.MissingParamNamefalse positive PHPCSStandards/PHP_CodeSniffer#535Per discussion on: