Repository navigation
[DeadCode] Retarget RemoveParentDelegatingClassMethodRector to Class_ node - #8824
Merged
Merged
Conversation
… node Subscribe to Class_ and resolve the class reflection from the node name via ReflectionProvider, instead of fetching scope per ClassMethod. Iterate the class methods once and drop the delegating ones.
TomasVotruba
force-pushed
the
retarget-remove-parent-delegating-to-class
branch
from
October 25, 2026 18:19
2d809af to
2ddbeca
Compare
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retargets
RemoveParentDelegatingClassMethodRectorfrom theClassMethodnode to theClass_node.The rule now resolves the class reflection straight from the class name via
ReflectionProvider, rather than fetching the scope on every visitedClassMethod. The parent class reflection is resolved once per class, then the class methods are iterated and the delegating ones dropped in a single pass.Rule and tests moved to the
Class_directory to match the subscribed node type.