Repository navigation
Make LogoutHandlerToLogoutEventSubscriberRector idempotent - #1080
Merged
Merged
Conversation
Skip a class already converted to EventSubscriberInterface. The class type can still resolve to the handler interface from stale reflection after the implements swap, so detect the converted state structurally instead of re-adding the interface and getSubscribedEvents() each pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running the rule more than once over the same class kept re-adding
EventSubscriberInterfaceand anothergetSubscribedEvents()method. After the implements swap the class type can still resolve toLogoutHandlerInterfacefrom stale reflection, so theisObjectType()guard stays true on later passes.The rule now detects an already-converted class structurally - it bails out when the implements list already contains
EventSubscriberInterface.Harmless today, but the upcoming rector-src node-traverser simplification drops the created-by-rule reprocessing guard, so each rule must settle on its own.
Rule test, ECS and PHPStan pass.