Skip to content

Automated Sync from main to stable - #40

Open
rhods-devops-app[bot] wants to merge 679 commits into
stablefrom
main
Open

rhods-devops-app[bot] wants to merge 679 commits into
stablefrom
main

Conversation

@rhods-devops-app

@rhods-devops-app rhods-devops-app Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Automated Sync from main to stable

This PR automatically syncs the main branch to the stable branch by opening a pull request from main into stable.

Sync Summary

  • Latest commit: 0ce70f9f0 Merge remote-tracking branch 'upstream/main'

  • Total commits to sync: 668

  • Source: https://github.com/red-hat-data-services/OpenShell.git @ main

  • Target: https://github.com/red-hat-data-services/OpenShell.git @ stable

  • PR head: main

Commits to be synced

Merging

GitHub automerge is enabled for this pull request once required checks pass.

Comment thread .github/workflows/codex-security.yml Dismissed
Comment thread .github/workflows/release.yml Fixed
Comment thread .github/workflows/snap-publish.yml Dismissed
@rhods-devops-app
rhods-devops-app Bot enabled auto-merge October 24, 2026 01:13
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0754473c-6e84-4bca-9ac5-ebff8cd19388

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review

Comment thread .github/workflows/release-auto-tag.yml Dismissed
Comment thread .github/workflows/release-prerelease.yml Dismissed
Comment thread .github/workflows/release.yml Dismissed
EmilienM and others added 3 commits November 5, 2026 07:20
musl's sigfillset and sigemptyset write only the first word of the
128-byte sigset_t on x86_64 and aarch64, so assuming the MaybeUninit
value is initialized reads 120 uninitialized bytes in
block_launcher_signals and install_child_signal_mask. Start both from
MaybeUninit::zeroed() so the whole value is defined regardless of how
much the libc writes, and correct the SAFETY comments accordingly. An
all-zero sigset_t is a valid empty set, so the mask handed to the kernel
is unchanged. The nix SigSet constructors were rejected as an
alternative because they hold the same uninit + assume_init pattern.

Adds tests that call both functions on their own thread, assert the
resulting mask state, and restore the previous mask afterwards, since
Miri cannot run this crate's FFI and seccomp-heavy tests.

Closes NVIDIA#5187

Signed-off-by: Emilien Macchi <emacchi@redhat.com>
* fix(ci): expose compatibility review failure diagnostics

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* fix(ci): simplify compatibility error reporting

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* fix(ci): pass through SDK errors without filtering

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* chore(ci): remove compatibility error test file

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
Signed-off-by: Yuedong Wu <dwcn22@outlook.com>
moulalis and others added 3 commits November 5, 2026 08:08
Signed-off-by: konflux-internal-p02 <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
Co-authored-by: konflux-internal-p02[bot] <170854209+konflux-internal-p02[bot]@users.noreply.github.com>
…IA#5248)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Co-authored-by: Matthew Grossman <mgrossman@nvidia.com>
alangou and others added 22 commits November 18, 2026 11:11
Update SQLx 0.9.0 to 0.9.1 and libsqlite3-sys 0.30.1/0.37.0 to 0.39.0 in all ten affected Cargo lockfiles for RUSTSEC-2026-0459. Remove the corresponding advisory exception and retain the reviewed Chrono unmaintained exception.

Signed-off-by: Adrien Langou <alangou@nvidia.com>
…ws (NVIDIA#5608)

* ci(e2e): cut fixed setup and teardown costs of the k3s conformance rows

Cache the tmachine setup layers for ubuntu-k3s too, and leave install
layers out of the disk cache: they hold the build under test and, on k3s,
the gateway's credentials. Install layers now live under disks/install so
the cache can take only the setup layers, keyed per environment.

Kill QEMU at session teardown instead of powering the guest off, since the
session overlay is thrown away. Layer builds still power off cleanly.

Pull the HA PostgreSQL fixture image in the k3s setup layer, and run the
prebuilt test program with a 180-second per-test limit instead of the
900-second default.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* ci(e2e): drop the test timeout and PostgreSQL pre-pull from the k3s fixed-cost change

Leave per-test timeouts to the runner work that owns them, and stop
pulling the PostgreSQL fixture image in the k3s setup layer, which saved
no measurable time and tied the tmachine cache key to e2e/.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* ci(e2e): wipe k3s credentials from the cached setup layer

The k3s setup layer boots k3s once, so it holds the cluster CA, token, node
password and admin kubeconfig. Stop k3s and delete that state before the layer
is saved, so each run's cluster generates its own credentials, and fail the
layer build if any credential file remains. Also key the disk cache on
ansible_hash.rs, which feeds the setup layer hash.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…4607)

Move e2e/rust workspace_lifecycle into a conformance workspaces suite on
#[testkit::test], split into workspace_full_crud_lifecycle,
template_is_scoped_to_its_workspace and workspace_terminating_rejects_creates.
Use a sandbox template as the scoped resource so no provider profile is
needed, and assert on exit status and listed state rather than message text.
A refused workspace delete is checked to leave the workspace Terminating, so
the failure is the resource guard rather than an unrelated error.

Add Context::cli_find_listed to testkit to find an entry in a paginated
--output json listing, erroring when the collection key is missing. Use it
in the workspaces suite and in conformance/src/cli.rs, and list it in the
testkit README.

Drop the legacy test, its Cargo target, and its Podman archive exclusion.

Signed-off-by: Evan Lezar <elezar@nvidia.com>
Signed-off-by: politerealism <burdcat17@gmail.com>
* chore(deps): upgrade Kubernetes client

Signed-off-by: Simon Scatton <sscatton@nvidia.com>

* docs: clarify Kubernetes tested baseline

Signed-off-by: Simon Scatton <sscatton@nvidia.com>

---------

Signed-off-by: Simon Scatton <sscatton@nvidia.com>
…5274)

Signed-off-by: John Myers <9696606+johntmyers@users.noreply.github.com>
…esh (NVIDIA#5668)

Signed-off-by: Eric Curtin <eric.curtin@docker.com>
…NVIDIA#5617)

* feat(docker): add opt-in persistent workspace storage

Refs NVIDIA#5484. Keep workspace data separate from disposable runtime resources, validate retained volume identity, and preserve legacy layouts. Workload image replacement and native qualification remain separate work.

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

* feat(docker): add stopped workload replacement component

Refs NVIDIA#5484. Preserve native identity and recorded data volumes while replacing workload bytes and refreshing container-bound runtime evidence. Keep update capability negotiation disabled pending lifecycle/restart integration and native qualification.

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

* feat(docker): integrate stopped image updates with lifecycle recovery

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

* fix(gateway): keep single-driver feature selections lint clean

Name the feature-selected registration array before iteration so Clippy does not flag the supported Docker-only build as a single-element loop. Driver entries, ordering and registration behavior remain unchanged.

Validation: cargo fmt --all --check and Docker-only gateway Clippy with compute-driver-docker, telemetry and vendored-z3, all targets and warnings denied.
Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

* fix(docker): validate update identity and repair launch rotation

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

* fix(docker): preserve legacy labels and qualify image updates

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

* fix(docker): record workspace ownership in protected driver state

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>

---------

Signed-off-by: Senthil Ravichandran <senthilr@nvidia.com>
…supervisor (NVIDIA#5669)

Add gateway.listenAddress and supervisor.listenAddress, defaulting to
0.0.0.0. Setting :: renders bracketed addresses such as [::]:8080.

Closes NVIDIA#5597

Signed-off-by: divesh <dgude@nvidia.com>
…ity (NVIDIA#5696)

Transparent egress to an IPv6 destination built an unbracketed
authority that parse_target rejects, so the connection was closed.

Closes NVIDIA#5693

Signed-off-by: divesh <dgude@nvidia.com>
…A#5674)

The chart renders OPENSHELL_PEER_ENDPOINT from an unbracketed pod IP,
which is not a valid URI on IPv6 clusters.

Closes NVIDIA#5673

Signed-off-by: divesh <dgude@nvidia.com>
* feat(gateway): export metrics over OTLP

Add an opt-in metrics signal that inherits shared OTLP collector
settings and operates independently of the Prometheus scrape listener.

Fan out existing metrics to both sinks when enabled. Serialize OTLP
gauge updates per series and give each gateway process a distinct
resource identity. The recorder follows the registry and gauge locking
approach in NVIDIA#4590.

Signed-off-by: Eitan Geiger <egeiger@redhat.com>

* fix(gateway): use latency buckets for OTLP queue waits

Apply the gateway latency buckets to OTLP histograms measured in
seconds. Extend the recorder test to verify queue-wait bucket bounds
and its Prometheus summary type.

Signed-off-by: Eitan Geiger <egeiger@redhat.com>

---------

Signed-off-by: Eitan Geiger <egeiger@redhat.com>
)

* feat(gateway): broker stable sandbox SPIFFE provider tokens

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* refactor(gateway): rename SPIFFE delegation configuration

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* fix(provider): reuse broker channels and attribute grant failures

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* test(provider): satisfy broker logging lint checks

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* fix(provider): harden broker caching and deployment prerequisites

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* refactor(identity): extract SPIRE sandbox identity adapter

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* refactor(identity): move shared SPIFFE types out of core

Signed-off-by: Drew Newberry <anewberry@nvidia.com>

* fix(supervisor): follow the sandbox reconciler leader (NVIDIA#4853)

* chore(sdk): drop regenerated frozen Go bindings

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(spiffe): verify provider tokens across supervisor failover

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* feat(crypto): verify TLS peers by SPIFFE identity

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* feat(spiffe): use Broker API for sandbox identity issuance

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(spiffe): verify broker authorization and credential rotation

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* docs(spiffe): clean up broker troubleshooting and test wording

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* feat(spiffe): authorize Broker agents across Kubernetes nodes

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(spiffe): send canonical credential keys to the gateway

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* perf(providers): resolve only the requested token grant profile

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(providers): bound broker admission and refresh expired cache hits

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* chore(server): remove unused protobuf codec dependency

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(spiffe): classify identity failures without retrying configuration errors

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(spiffe): unify gateway identity configuration and document shared grants

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(providers): verify targeted snapshot freshness and cache reuse

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(spiffe): support remote fixtures and remove CSI consumers before teardown

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(providers): validate uncached sources before selecting a grant

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(spiffe): validate agent replacement and remote supervisor failover

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* feat(spiffe): connect the gateway to its node-local Broker agent

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(spiffe): validate node-local Broker routing across gateway relocation

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(ci): satisfy certificate test lint and refresh merged lockfile

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(crypto): initialize OpenSSL for SPIFFE certificate verification

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* chore(spiffe): remove prototype tooling and stale guidance

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(providers): share acquisition failures with waiting requests

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* fix(core): initialize provider-token channels without eager connects

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

---------

Signed-off-by: Drew Newberry <anewberry@nvidia.com>
Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
Co-authored-by: Taylor Mutch <taylormutch@gmail.com>
…IDIA#5691)

* test(testkit): add providers, run_python, last_json, policy readers and binaries_yaml

Shared helpers for suites that run client scripts in a sandbox: attach providers from the sandbox builder, run a Python script and read its JSON result, read a sandbox's policy revisions and active policy, and write a binaries list into hand-written policy YAML.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(host-server): add TEST_HOST

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(support): add sandbox-clients crate with connect and http probes

A shared home for the clients tests run inside a sandbox. One probe script connects, optionally sends bytes, and reads until the connection ends; connect(), http() and http_raw() run it and return typed results. HTTP parsing happens in Rust and is unit-tested. Requests send Connection: close by default, and raw sends stop after two idle seconds, so a keep-alive server can't stall a read.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(features): use shared helpers in host-gateway

The test uses TEST_HOST and the sandbox-clients http probe in place of its own Python client. Its main changes from sh -c "exec sleep infinity" to sleep infinity, which leaves the same final process.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(suites): drop ready_sandbox wrappers and unify long-running commands

Tests create a long-running sandbox with the builder chain directly instead of a per-file ready_sandbox helper. The cli and policy-advisor mains change from sh -c "exec sleep infinity" to sleep infinity, which leaves the same final process. connect-ssh-supervision keeps its sh -lc mains.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* docs(testkit): list the shared sandbox helpers

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(suites): use shared sandbox and provider helpers in cli, cdi and keycloak tests

The cli tests read sandbox get JSON through Sandbox::get_json, the cdi scenario creates its sandbox with cli_sandbox, and the keycloak refresh test installs its provider with install_provider instead of importing the profile and creating the provider by hand.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test: trim unit tests for the shared sandbox helpers

The e2e suites exercise the helpers. Keep only the HTTP parser tests for chunked bodies and non-HTTP bytes, which no e2e test reaches yet.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(features): leave the keycloak refresh test to NVIDIA#5657

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

NVIDIA#5657 makes the same install_provider change in that file along with its typed profile, so this branch leaves it unchanged to avoid a conflict.

* test(testkit): fail early on sandbox names the gateway rejects

The gateway limits sandbox names to 19 characters, which leaves 5 for a suffix after test-<run-id>-. cx.sandbox, cx.cli_sandbox and cx.track now panic at the test's call with that explanation, instead of the test failing later with the gateway's validation error. Context::name is unchanged, since provider and profile names have no such limit.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* docs(testkit): document how to write a sandbox client

The testkit README now explains why clients run in the sandbox, the contract a client script follows, and when a script moves to sandbox-clients. tcp_probe.py points to it, sandbox-clients says it holds network clients only, TESTING.md points Rust tests to run_python, and run_python suggests python_image() when the sandbox has no python3.

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* test(conformance): use the shared TEST_HOST in credential gating

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* fix(support): report DNS failures from the connect probe as dns, not errno

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* refactor(support): drop the unused is_dns_failure helper

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* refactor(support): parse HTTP replies with httparse

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* fix(support): report a stalled send from the connect probe as a timeout

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

* docs(testkit): link the sandbox client guide and the server name limit

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>

---------

Signed-off-by: Matthew Grossman <mgrossman@nvidia.com>
…urces (NVIDIA#5612)

Records for provider, credential, configuration, and draft policy changes
named nothing, so an auditor could not tell which provider, credential
key, setting, or draft chunk a call changed, and could not see the value
a setting was given.

Name the provider and credential key, the sandbox and setting key, and
the sandbox and draft chunks, plus the resulting policy hash. Add
[openshell.gateway.audit] capture_setting_values to record the value of
a registered setting when it has the registered type. Credential values,
refresh material, review tokens, rejection reasons, and proposed rules
are never recorded, and canary tests cover each. A record over the
resource cap keeps its last resource, the result of the change, and
authorization denials apply the same cap and value bounds.

Signed-off-by: Kris Hicks <khicks@nvidia.com>
TaylorMutch and others added 7 commits November 19, 2026 01:26
…A#5733)

* test(grpc): generate default handlers for partial test servers

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

* test(cli): remove remaining unused gateway mock handlers

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>

---------

Signed-off-by: Taylor Mutch <taylormutch@gmail.com>
…e natively (NVIDIA#5212)

* fix(sandbox): set si_signo in rt_sigqueueinfo mediation

The rt_sigqueueinfo emulation passed the workload's siginfo to
pidfd_send_signal unchanged, but the kernel rejects a siginfo whose
si_signo differs from the signal argument with EINVAL, while native
rt_sigqueueinfo overwrites si_signo with the requested signal. A
workload that leaves si_signo unset therefore failed only under
OpenShell.

Mirror the kernel by overwriting si_signo after the existing si_code
check, and cover it with a forked-child test that queues a signal with
a deliberately mismatched si_signo and asserts the delivered signo and
value.

Signed-off-by: Emilien Macchi <emacchi@redhat.com>

* fix(sandbox): continue self-directed signals natively

A self-directed kill or rt_sigqueueinfo was emulated by sending through
the retained pidfd while the caller was still blocked in its seccomp
notification, so the delivered signal interrupted the very syscall
being emulated: without SA_RESTART the call returned EINTR, and with
SA_RESTART it restarted and was notified again.

Continue the notification instead when the target group is the
notifying thread's own group. The kernel then executes the syscall
after the notification wait, so its result and siginfo are the
workload's own: an errno such as EAGAIN under an exhausted
RLIMIT_SIGPENDING stays visible, si_pid and si_uid name the workload
rather than the broker, and a handler runs exactly when it would
without mediation. The frozen-workload SIGCONT gate and the
queued-signal si_code check stay ahead of the continuation; other
targets keep the retained-pidfd delivery. Continuing an inspected
numeric target has the same PID-reuse window as the tkill precedent.

Cover it with forked-child tests: a self-directed kill, a kill that
names a sibling thread's TID, and a self-directed queued signal
complete natively with the handler observed, and a queued signal under
a zero RLIMIT_SIGPENDING reports the native EAGAIN instead of success.

Signed-off-by: Emilien Macchi <emacchi@redhat.com>

* fix(sandbox): mediate sched, prlimit64, and setpriority for own process group

The child hardening filter denied sched_setaffinity, sched_setattr,
sched_setparam, sched_setscheduler, and prlimit64 for any nonzero PID
argument and setpriority outright, so thread pinning
(pthread_setaffinity_np and GOMP_CPU_AFFINITY pass a kernel TID),
taskset -p, psutil cpu_affinity(pid), prlimit(getpid()), and nice all
failed with EPERM inside sandboxes while working in a plain container.

A cBPF filter cannot compare an argument against the caller's own
thread group, and SECCOMP_RET_ERRNO outranks the user-notification
action, so the denies cannot be narrowed in place. Move the six
syscalls to broker mediation instead: the workload listener now
notifies them when they name a target, and the broker continues the
call when the target is in the caller's own thread group (own TGID or
a sibling TID resolved through /proc), preserves ESRCH for vanished
targets, and fails closed with EPERM for everything else, including a
caller it cannot identify. setpriority is limited to
PRIO_PROCESS, since PRIO_USER names every process of the shared
workload UID and PRIO_PGRP names a group an untrusted child can rejoin.
The static filter keeps an equal-deny on the trusted sandbox leader as
defense in depth, on argument 1 for setpriority whose PID is the
second argument.

A call with pid 0 names only the caller, which cBPF can check, so the
listener filter allows it without a notification (for setpriority only
under PRIO_PROCESS). Those calls keep their native, non-interruptible
behavior, and the prlimit64(0, ...) the pre-exec hardening hook issues
never waits on the broker. A child that does not inherit the workload
listener, the socket probe, takes prepare_without_broker, which keeps
the previous static rules. Shared /proc thread-group resolution moves
to linux/proc_status and the new mediation lives in
linux/process_sched.

Cover the filter and broker with allow, deny, ESRCH, and native pid 0
path tests, and add an e2e that runs inside a real sandbox: thread
affinity, self and sibling-TID signals, nice, a raw prlimit64, a
queued signal with a mismatched si_signo, and denied calls against a
same-UID child and the sandbox parent.

Signed-off-by: Emilien Macchi <emacchi@redhat.com>

---------

Signed-off-by: Emilien Macchi <emacchi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.