Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
+ Coverage 0.00% 40.88% +40.88%
==========================================
Files 4 124 +120
Lines 26 5337 +5311
Branches 0 1018 +1018
==========================================
+ Hits 0 2182 +2182
- Misses 26 2866 +2840
- Partials 0 289 +289 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…e config lists Bundle KubeConfig with its source path in a KubeConfigFile data class so callers carry the file path alongside the parsed config, and replace the process-wide WeakHashMap path-to-config cache with direct per-call parsing. All config APIs now return List<KubeConfigFile>, and mechanical type updates propagate through KubeConfigUtils, KubeConfigUpdate, KubeConfigTlsWriter, LinkClientBuilder, DevSpacesServerStepView and their tests. No behavior change. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Previously, when the user had no kubeconfig at all (no ~/.kube/config and no KUBECONFIG entries), all config lists were empty and the create-context operations silently returned without writing anything, so the wizard appeared to finish but no kubeconfig was ever created. - KubeConfigUtils: add getDefaultConfig() (always ~/.kube/config), getWritableConfig() (first KUBECONFIG entry, defaulting to the standard path) and newEmptyConfig(path). - KubeConfigUpdate: CreateContext and CreateContextWithClientCert now fall back to an empty config at the writable path instead of returning; saveConfig takes a non-null path and creates missing parent directories. - getAllConfigFiles no longer filters out a non-existent default path so FileWatcher can pick it up once the wizard creates it. - Add unit tests for the new utils methods and the create-on-empty flows. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…rw-12054) FileWatcher now tracks files whose parent dir doesn't exist and re-registers the directory once it appears, notifying listeners. KubeConfigMonitor relies on addFile idempotency instead of pre-deduplicating paths. Signed-off-by: Andre Dietisheim <adietish@redhat.com> Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes https://redhat.atlassian.net/browse/CRW-12054