fix some test flakes 1-009 1-012 & 1-067

[trdoyle81]

What type of PR is this?
/kind failing-test

What does this PR do / why we need it:

Hardens three flaky tests that have been failing Kind/Prow on some PRs (including UI tests).

The flakes were races not slow tests so no bump assertion timeouts:

• 1-009 / 1-012: wait until dest-namespace controller RBAC (and the cluster secret listing the ns) is in place before creating the app.
• 1-067: HaveReadyReplicas can pass on old Redis HA pods mid-rollout then exec reads pre-TLS redis.conf. Wait for the SS spec to mount TLS a completed rollout (currentRevision == updateRevision) and then server-0 to be the post-TLS pod. (drops the 10m wait).

Have you updated the necessary documentation?

• Documentation update is required by this PR.
• Documentation has been updated.

Which issue(s) this PR fixes:

CI flake fixes

Test acceptance criteria:

• Unit Test
• E2E Test

How to test changes / Special notes to the reviewer:

These are test-only changes.
parallel/1-009_validate-manage-other-namespace
sequential/1-012_validate-managed-by-chain
sequential/1-067_validate_redis_secure_comm_no_autotls_ha

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign anandf for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 4d933e48-c65a-49dc-b23d-78f9b6b745c8

📥 Commits

Reviewing files that changed from the base of the PR and between 7535fa9 and cb395de.

📒 Files selected for processing (1)

• test/openshift/e2e/ginkgo/fixture/statefulset/fixture.go

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• argoproj-labs/argocd-operator (manual)

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.

---

📝 Summary

Summary by CodeRabbit

• Tests
  • Improved OpenShift end-to-end test reliability by validating StatefulSet rollout completion, revision updates, generation synchronization, and readiness before proceeding.
  • Added checks confirming controller permissions, service account bindings, and managed namespace configuration before cross-namespace operations.
  • Strengthened Redis high-availability testing to verify TLS secret mounting and updated pod readiness.
  • Adjusted polling intervals and timeouts to better accommodate asynchronous environment changes and reduce premature test failures.

Walkthrough

Changes

E2E synchronization

Layer / File(s)	Summary
StatefulSet rollout contract test/openshift/e2e/ginkgo/fixture/statefulset/fixture.go	Adds HaveCompletedRollout, which checks ready and updated replica counts, matching non-empty revisions, and observed generation synchronization.
Redis rollout validation test/openshift/e2e/ginkgo/sequential/1-067_validate_redis_secure_comm_no_autotls_ha_test.go	Waits for the Redis StatefulSet and pod to use the updated revision and TLS secret before configuration checks.
Namespace resource synchronization test/openshift/e2e/ginkgo/parallel/1-009_validate-manage-other-namespace_test.go, test/openshift/e2e/ginkgo/sequential/1-012_validate-managed-by-chain_test.go	Waits for Roles, RoleBindings, and cluster-secret namespace data before creating applications. Application polling intervals increase from 1 second to 5 seconds.

Priority: ⬇️ Low — Defer this test-only change because it hardens three flaky E2E tests without changing production behavior.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Merge Risk: ⚪ Minimal · up to 43ab9

This test-only change makes E2E synchronization wait for completed StatefulSet rollout conditions, reducing race-related flakes without changing product runtime behavior.

Sequence Diagram(s)

sequenceDiagram
  participant RedisTest
  participant RedisStatefulSet
  participant RedisPod
  RedisTest->>RedisStatefulSet: wait for completed rollout
  RedisTest->>RedisStatefulSet: verify generation and TLS secret mount
  RedisTest->>RedisPod: verify running, ready, updated revision, and TLS mount
  RedisTest->>RedisPod: check Redis and Sentinel configuration

Loading

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 4 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the three flaky tests addressed by the changes.
Description check	✅ Passed	The description accurately explains the race-condition fixes and the test-only scope.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[trdoyle81]

/retest

[openshift-ci]

@trdoyle81: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/v4.14-kuttl-sequential	43ab943	link	false	/test v4.14-kuttl-sequential
ci/prow/v4.19-kuttl-sequential	43ab943	link	true	/test v4.19-kuttl-sequential

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.