Repository navigation
docs(deposit-addresses): explain non-custodial design - #562
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Automations to automatically generate PRs for you. |
|
Claude finished @ted-uneven's task in 44s —— View job Code reviewI found 2 problems in 1. "Funds can only be swept into the Depository" and "Funds stay recoverable" conflict with the feature guide The new text says this in three places: line 9, line 45 ("can't move the funds to an address of its choosing") and line 48. But the feature guide describes funds that leave a deposit address without being swept or refunded:
There's also a contradiction inside the new bullet at line 48. It says the signer "won't sign a transfer to an address the order doesn't specify," which implies it will sign transfers to addresses the order does specify. That reads as weaker than "only into the Depository." This conflicts with AGENTS.md §1.2: "Ground 'decentralized,' 'trustless,' and 'non-custodial' in verified mechanics and scope … Do not replace security explanations with absolute guarantees." Suggested fix: limit the claims to supported deposits, for example "Deposits of supported tokens can only be swept into the Depository." Also say how unsupported tokens and dust are recovered, or link to the feature guide's Supported Currencies and refund sections. Drop or reword the "address the order doesn't specify" sentence so it doesn't conflict with "only into the Depository." relay-docs/references/protocol/components/deposit-addresses.mdx Lines 44 to 50 in 5428419 2. "No one holds the key" doesn't match its own explanation, and the signer's trust assumptions are missing The heading on line 47 says no one holds the key. The sentence after it says the key exists inside a TEE signer. Elsewhere the docs call that "the protocol's TEE signer" ( The section never says:
AGENTS.md §1.2 requires these: "Preserve signer, permission, upgrade, halt, and recovery assumptions." Suggested fix: rename the bullet to something like "Keys stay inside a TEE." Then add one sentence on who operates the signer, what the guarantee relies on (TEE integrity and the signer's policy), and how that policy is controlled or upgraded. relay-docs/references/protocol/components/deposit-addresses.mdx Lines 46 to 48 in 5428419 I also checked the links: |
[Low impact] This documentation change appears safe to merge.
|
No description provided.