Repository navigation
chore(example): bump ROU, TUR contract_details schema versions - #1819
Open
gabrielseco wants to merge 1 commit into
Open
gabrielseco wants to merge 1 commit into
gabrielseco wants to merge 1 commit into
Conversation
The schema snapshot seed treats a 422 from the engagement agreement form as 'no form for this country', as it already does for a 404, since the sandbox answers 422 for Romania and Turkey.
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (307 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report✅ Coverage increased! 🎉
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pins the example app to the latest contract details schema versions for Romania (v6) and Turkey (v7), with snapshots and migration guides.
Why
Both countries were still pinned to v1 while newer versions are served. Earlier country bumps followed the same steps.
What changed
Toggle details
ROU.v6.jsonandTUR.v7.json, generated withpnpm run schema-snapshot --create-missing.ROU.mdandTUR.mdmigration guides, and the countries README rows updated. Each guide has one "current" entry summarizing all changes since v1, because the snapshots only provide a v1 to latest diff, not one per version.Screenshots
N/A
Related Resources
Testing
pnpm run type-check,lintandcheck-formatpass locally;utils.test.tspasses. The full suite runs in CI.Tested against the
example/app in a browserFeature flag: N/A
Note
Low Risk
Mostly version pins, documentation, and example configuration; the seed script change only broadens an existing skip path for optional forms.
Overview
Updates Romania and Turkey to current contract details schema versions and documents how integrators should migrate.
The example app now pins ROU to v6 and TUR to v7 (was v1). Romania and Turkey are added to the JSF v1 contract-details country list so onboarding uses the build-once headless form path, with matching test coverage.
New country guides
ROU.mdandTUR.mdsummarize compliance-driven field changes since v1, and the countries README matrix links them and marks both as up to date for October 2026.Schema canary
seed-employmentnow skips missingengagement_agreement_detailswhen the API returns 422 as well as 404, so snapshot/seeding works for countries where that form is unavailable in sandbox.Reviewed by Cursor Bugbot for commit b0385f9. Bugbot is set up for automated code reviews on this repo. Configure here.