fix: removed tty allocation in docker run - #1056
Merged
Merged
Conversation
Contributor
Author
|
@viceice Hey - could you please look at this PR? 🙏 |
viceice
changed the title
viceice
changed the title
Contributor
Author
|
Hey @viceice - is there any chance this gets merged anytime soon? 🙏 |
viceice
reviewed
Sep 2, 2026
viceice
left a comment
viceice
left a comment
Member
There was a problem hiding this comment.
sorry, forgot to finish the review
radekl
force-pushed
the
customizable-docker-tty
branch
from
September 3, 2026 09:41
acb6cff to
4c112bd
Compare
radekl
changed the title
viceice
approved these changes
Sep 21, 2026
viceice
enabled auto-merge (squash)
September 21, 2026 09:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have been stuck with a single repository timing out while we run renovate on it using github actions. There were little to no errors we could work on, but eventually we were able to tell that the issue is probably with renovate waiting for some input. Due to the PR #974 it caused the action to hang and timeout didn't work.
This PR adds an option to choose whether to allocate TTY or not to a docker run, so such situations doesn't happen. We have tested it to work pretty well on our configuration (and we care a bit more about job being done than having colorful output 😅 )
edit:
after review (see comments below) decision is to drop TTY allocation and basically revert changes from #974.