Skip to content

Re-record e2e golden recordings and run the e2e tests against processor sessions in CI - #10683

Open
markerikson wants to merge 9 commits into
feature/processor-session-supportfrom
feature/processor-session-e2e-recordings
Open

markerikson wants to merge 9 commits into
feature/processor-session-supportfrom
feature/processor-session-e2e-recordings

Conversation

@markerikson

Copy link
Copy Markdown
Collaborator

Stacked on #10682.

This PR:

  • Re-records all automatic golden examples in examples.json on the current runtimes (Chromium linux-chromium-20261021-8febdce13963-9c1a8933f184, Node linux-node-20261021-11f86308a684-ce6ad2a40008)
    • Replaces the 2024 logpoints-01 recording with one from this branch's CI run. The old one predates registerRootFrameScript, so processor sessions reported React analysis as failed and react_devtools-02 couldn't pass
    • Updates the tests whose expectations come from these recordings: jump-to-code-02, logpoints-10, logpoints-11, react_devtools-02, react_devtools-03. DevTools itself now ships React 19, so logpoints-10/11 target react-dom-client.production.js
  • Updates the rdt-react-versions example: drops the React 15 app, adds a React 19 root, and rebuilds it
    • Keeps React 16. Processor sessions don't resolve React 16 component names, so react_devtools-03 checks those names only on controller sessions
  • Adds a doc_long_busy.html example (about 2 minutes, a tick every 250 ms, 24 clicks) and focus_mode-02, which covers focus windows longer than 60 s, narrowing and widening the window, and jump-to-code inside and past the focus window
    • Adds a per-example recordingTimeout option to save-examples.ts, for recordings that take longer than the 60 s default
    • Fixes clearTimeInput in the timeline test helpers, which looped forever on values like 1:07
  • Prefetches screenshots ahead of video playback (3 s lookahead, at most 5 requests in flight). On processor sessions, the first screenshot in each region can take seconds, so playback stalled at region boundaries and playwright-04 failed
  • Adds an e2etest-processor GHA job that runs the e2e suite with E2E_PROCESSOR_SESSIONS=1 (10 shards, 2 workers per shard since processor sessions start cold)

Locally, against a production build, the full suite passes on both controller and processor sessions. The only failures were tests that failed with 4 workers running in parallel and passed when rerun by themselves.

Note that this leaves the 5 other manually recorded examples (Cypress/Playwright test-runner recordings and deleted-replay) as they are, and it doesn't delete the replaced recordings from the golden workspace.


🤖 Description

  • The rebuilt rdt-react-versions output was force-added, because the root .gitignore excludes dist.
  • The long busy example keeps its script in long_busy.js instead of inline in the HTML. Jump-to-code ignores handlers whose source URL isn't a .js/.ts file (backend shouldIgnoreSource), so a handler in an inline <script> always shows "No results".
  • When a handler is past the end of the focus window, jump-to-code finds it and moves the timeline there on both session types. DevTools then doesn't pause there, because seek refuses points outside the focus window, which is existing behavior. focus_mode-02 asserts only that the timeline moves.

@markerikson
markerikson added this pull request to stack #10684 October 27, 2026 14:56
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
devtools Ready Ready Preview Nov 3, 2026 10:03pm UTC

Request Review

@socket-security

socket-security Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedreact@​15.7.0 ⏵ 19.3.1100 +310084 +597100
Updatedreact-dom@​15.7.0 ⏵ 19.3.1100 +4210092 +398100

View full report

@socket-security

socket-security Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Caution

Review the following alerts detected in dependencies.

According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.

Priority Alert  (click "▶" to expand/collapse) Action
Low priority
Potential security risk (AI signal): npm react-dom is 62.0% likely risky

Notes: This module is a minimal CommonJS wrapper that unconditionally loads and exports a local native addon binary (./static.node). The JavaScript wrapper itself is benign-looking and contains no direct malicious logic, but it creates a significant supply-chain risk because all potentially sensitive behavior is implemented inside an opaque compiled addon. Inspect static.node (and its build/signing provenance) for network/FS/process actions, persistence behavior, hardcoded endpoints/credentials, and any unexpected runtime activity.

Confidence: 0.62

Severity: 0.70

From: packages/e2e-tests/examples/rdt-react-versions/react-19-app/package.json → npm/react-dom@19.3.1

ℹ Read more on: This package | This alert | What are AI-detected potential security risks?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: An AI system identified potential security problems in this package. It is advised to review the package thoroughly and assess the potential risks before installation. You may also consider reporting the issue to the package maintainer or seeking alternative solutions with a stronger security posture.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/react-dom@19.3.1. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Block

View full report

- Re-record all automatic browser and Node examples, and use a fresh logpoints-01 recording
- Update tests for the new recordings and for processor-backed sessions
- doc_long_busy.html + long_busy.js: ticks every 250 ms, 24 clicks 5 s apart, one held click
- save-examples: per-example recordingTimeout
- focus_mode-02: >60 s focus window, narrow/widen, jump-to-code inside and past the focus window
- clearTimeInput: fill "0" instead of backspacing (hung on values like 1:07)

This branch was successfully deployed

1 active deployment
Preview — ad2bdcde Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant