Repository navigation
Re-record e2e golden recordings and run the e2e tests against processor sessions in CI - #10683
markerikson wants to merge 9 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Caution Review the following alerts detected in dependencies. According to your organization's Security Policy, you must resolve all "Block" alerts before proceeding. Learn more about Socket for GitHub.
|
a34a1a7 to
310f126
Compare
- Re-record all automatic browser and Node examples, and use a fresh logpoints-01 recording - Update tests for the new recordings and for processor-backed sessions
- doc_long_busy.html + long_busy.js: ticks every 250 ms, 24 clicks 5 s apart, one held click - save-examples: per-example recordingTimeout - focus_mode-02: >60 s focus window, narrow/widen, jump-to-code inside and past the focus window - clearTimeInput: fill "0" instead of backspacing (hung on values like 1:07)
310f126 to
02cb917
Compare
Stacked on #10682.
This PR:
examples.jsonon the current runtimes (Chromiumlinux-chromium-20261021-8febdce13963-9c1a8933f184, Nodelinux-node-20261021-11f86308a684-ce6ad2a40008)logpoints-01recording with one from this branch's CI run. The old one predatesregisterRootFrameScript, so processor sessions reported React analysis as failed andreact_devtools-02couldn't passjump-to-code-02,logpoints-10,logpoints-11,react_devtools-02,react_devtools-03. DevTools itself now ships React 19, sologpoints-10/11targetreact-dom-client.production.jsrdt-react-versionsexample: drops the React 15 app, adds a React 19 root, and rebuilds itreact_devtools-03checks those names only on controller sessionsdoc_long_busy.htmlexample (about 2 minutes, a tick every 250 ms, 24 clicks) andfocus_mode-02, which covers focus windows longer than 60 s, narrowing and widening the window, and jump-to-code inside and past the focus windowrecordingTimeoutoption tosave-examples.ts, for recordings that take longer than the 60 s defaultclearTimeInputin the timeline test helpers, which looped forever on values like1:07playwright-04failede2etest-processorGHA job that runs the e2e suite withE2E_PROCESSOR_SESSIONS=1(10 shards, 2 workers per shard since processor sessions start cold)Locally, against a production build, the full suite passes on both controller and processor sessions. The only failures were tests that failed with 4 workers running in parallel and passed when rerun by themselves.
Note that this leaves the 5 other manually recorded examples (Cypress/Playwright test-runner recordings and
deleted-replay) as they are, and it doesn't delete the replaced recordings from the golden workspace.🤖 Description
rdt-react-versionsoutput was force-added, because the root.gitignoreexcludesdist.long_busy.jsinstead of inline in the HTML. Jump-to-code ignores handlers whose source URL isn't a.js/.tsfile (backendshouldIgnoreSource), so a handler in an inline<script>always shows "No results".seekrefuses points outside the focus window, which is existing behavior.focus_mode-02asserts only that the timeline moves.