[HTTPXodus] migrate httpx to httpx2 with dual import - #471
Open
ProgrammerPlus1998 wants to merge 1 commit into
Open
[HTTPXodus] migrate httpx to httpx2 with dual import#471ProgrammerPlus1998 wants to merge 1 commit into
ProgrammerPlus1998 wants to merge 1 commit into
Conversation
Refs: HTTPXodus campaign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #470
What this PR does
This is the implementation of the migration discussed in the linked issue. It switches
replicate/replicate-python's HTTP client fromhttpxtohttpx2via dual import: on Python ≥ 3.10 the runtime binds tohttpx2; on 3.9 the import falls back tohttpx.requires-pythonis not changed.Diff summary
N files, +A / −B (commit
f2fb991):pyproject.tomlhttpx2>=2.12.0; python_version >= "3.10"next to the existinghttpxruntime depreplicate/**import httpx→ dual import (Option A)The public API surface is preserved because the dual-import alias keeps the name
httpxeverywhere. No call-site changes are needed beyond the import.Test results
Validated in a fresh venv on Python 3.12 with both
httpxandhttpx2installed (SUT resolves tohttpx2):pip install -e ".[dev]"resolves to bothpython -c "import replicate; ..."smoke test passesNotes for reviewer
httpx.Client/httpx.AsyncClient/httpx.Response.raise_for_status()types used inreplicateexist in bothhttpxandhttpx2with identical signatures, so no call-site changes are needed beyond the import.httpx2verifies TLS against the OS trust store instead of the bundledcertifi. Replicate SDK deployments that rely on a custom CA bundle may needSSL_CERT_FILE/SSL_CERT_DIRafter the switch. Worth a line in the changelog.requires-pythonfloor is belowhttpx2's>=3.10floor, and dropping 3.9 would be out of scope. If replicate-python later raises the floor, this can be replaced with a hardimport httpx2 as httpxin a follow-up.Happy to revise per review — and equally happy to close this PR if the maintainers would rather wait for
httpx1.0 stable. 🙏