fix(create-email): validate npm registry response and exit on invalid version - #3741
Open
Tyagiquamar wants to merge 1 commit into
Open
Tyagiquamar wants to merge 1 commit into
Tyagiquamar wants to merge 1 commit into
Conversation
… version Signed-off-by: Tyagiquamar <mohdquamartyagi@gmail.com>
Contributor
|
@Tyagiquamar is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check response.ok when querying npm registry in getLatestVersionOfTag inside create-email. Immediately exit with error status if the npm HTTP request fails, tag is not found, or the version format is invalid/empty, preventing create-email from silently writing undefined versions into starter package.json.
Summary by cubic
Fixes
create-emailto validate the npm registry response and exit with an error when the request fails or the version is empty/invalid, instead of silently writingundefinedinto the starterpackage.json.Written for commit b334d41. Summary will update on new commits.