Skip to content

fix: allow null optional inbox params - #300

Merged
dielduarte merged 2 commits into
resend:mainfrom
mayankbohradev:fix/nullable-email-params
Oct 29, 2026
Merged

dielduarte merged 2 commits into
resend:mainfrom
mayankbohradev:fix/nullable-email-params

Conversation

@mayankbohradev

@mayankbohradev mayankbohradev commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Mark optional nullable Inbox reply and forward fields as accepting None.
  • Mark nullable draft attachment and send-header fields as accepting None.
  • Add a regression test covering all affected fields.

Verification

  • Regression fixture produced 10 mypy errors before the annotation fix.
  • tox: format, lint, mypy, and pytest passed (852 tests; 10 existing deprecation warnings).
  • Re-ran lint, mypy, and pytest after removing unrelated formatter output; all passed.

Summary by cubic

Updates the inbox SDK type hints so optional reply, forward, and draft parameters accept None instead of only being omittable. Affected fields include cc, bcc, headers, and attachments on reply and forward params, plus attachments on draft create params and headers on draft send params. Adds a regression test verifying these fields are sent as null in the API request.

Written for commit a0a76c8. Summary will update on new commits.

View guided diff

@codecov-commenter

codecov-commenter commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.62%. Comparing base (7f1acd0) to head (a0a76c8).
⚠️ Report is 245 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #300       +/-   ##
===========================================
+ Coverage   82.66%   97.62%   +14.95%     
===========================================
  Files           4       89       +85     
  Lines          75     5513     +5438     
===========================================
+ Hits           62     5382     +5320     
- Misses         13      131      +118     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions Bot added the linear-synced PR has been synced to Linear label Oct 18, 2026
@dielduarte
dielduarte self-requested a review October 29, 2026 15:31
Move the regression test into inboxes_test.py following the
TestInboxesRequest pattern, and bump version to 2.50.1.
@dielduarte
dielduarte merged commit e78ad17 into resend:main Oct 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear-synced PR has been synced to Linear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants