Repository navigation
Conversation
try py 3.9
…uggests it should?)
ignore missing variables (since `_version` is loaded via an include). to fix CI script failure with code `F821` see respec#135 (comment)
ignore ACIDPH.py because it uses a weird sci notation format AC (i.e. I think `rkal1 = 1.03d-5` should be `rkal1 = 1.03e-5` etc)
set python 3.8 for install to make all the things work
py 3.8 fails with error in `build/lib/HSP2/ACIDPH.py` (same as HSP2/ACIDPH.py) so exclude that too
Develop pandas3 prep
… just OPN SEQUENCE
Throw error when elements appear in SPEC-ACTIONS but not in OPSEQ
* Default and validation when reading in all parameters. * Default and validation support metric or english units as appropriate. * Parameter reading function for UCI returns dictionary of pandas DataFrames keyed to the HDF table names. * Reads UCI supplemental files. * Reads UCI and WDM files from local files or URIs. src/hsp2/hsp2/ATEMP.py: if ELDAT=0 then can just return. src/hsp2/hsp2/GENER.py: removed UCI parsing code, as it is not needed for the new implementation. src/hsp2/hsp2/GQUAL.py: refactor src/hsp2/hsp2/HYDR.py: remove unused hydr_load_om, fix DEWTEMP -> DEWTMP, refactor src/hsp2/hsp2/PWATER.py: ui["ICEFG"] must be an integer not a float, refactor src/hsp2/hsp2/RQUAL.py: PKCF1_ and PKCF2_ need to be PKCF1 and PKCF1 respectively, refactor src/hsp2/hsp2/SEDTRN.py: expand_SEDTRN_metadata, refactor src/hsp2/hsp2/SNOW.py: refactor src/hsp2/hsp2/main.py: In one place OXFG -> OXRX, refactor src/hsp2/hsp2/utilities.py added deprecated decorator function added _normalize_memsb function src/hsp2/hsp2io/control_file_readers/read_uci_parameters.py parse both local and remote UCI files src/hsp2/hsp2io/control_file_readers/utils.py fill defaults and validate the parameters src/hsp2/hsp2io/hdf.py: for GENER there was partial processing of UCI files, but this is no longer needed, so removed/changed. src/hsp2/hsp2io/time_series_readers/read_wdm_ts.py read both local and remote WDM files src/hsp2/hsp2tools/readUCI.py internally shifted to use new functions, marked deprecated src/hsp2/hsp2tools/readWDM.py internally shifted to use new functions, marked deprecated src/hsp2/state/state.py Have to bypass DISPLY and PLTGEN since only used in HSPF
Contributor
Author
|
Mistake to make the pull request to master instead of developing... closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path to WDM files, relative to the UCI file, is now correctly determined.