Repository navigation
Feat/container - #4
Merged
Merged
Conversation
nymous
requested changes
Nov 7, 2026
nymous
left a comment
nymous
left a comment
Member
There was a problem hiding this comment.
Awesome! Of all the comments the only blocker would be the SELinux, the rest are nice-to-have.
As I said I will modernize the code soon, which will limit the dependencies, simplify the Dockerfile...
And if you still have some energy, I would love for the CI to build run checks and build the image on push/pull requests as well, and only push on a release. If not it's fine as-is ^^
| - BLOCK_UNDEFINED_EVENTS=${BLOCK_UNDEFINED_EVENTS:-false} | ||
| volumes: | ||
| # Edit the filters without rebuilding the image, restart the container to apply them | ||
| - ./src/filterConfiguration.json:/usr/src/app/dist/src/filterConfiguration.json:ro,z |
Member
There was a problem hiding this comment.
Also I think having a friendlier path than /usr/src/app/dist/src would be nice ^^ something like /app/filterConfiguration.json (which means moving the copied file in the Dockerfile).
I have a "2026 update" coming later that will simplify many things, so you can let it go until then.
nymous
approved these changes
Nov 8, 2026
| - uses: docker/setup-buildx-action@f87e5991a6d7451dcb8d9637bfbc97413f497069 # v4.4.1 | ||
|
|
||
| - uses: docker/login-action@dbcb813823bdd20940b903addbd779551569679f # v4.6.0 | ||
| if: github.event_name == 'release' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for building a container using Github Action (CI, compose file...) and a fix written along the way.