Skip to content

Add KillAura option to ignore named mobs - #334

Merged
rfresh2 merged 2 commits into
rfresh2:1.21.4from
zyckk4:feat/killaura-ignore-named-mobs
Sep 25, 2026
Merged

rfresh2 merged 2 commits into
rfresh2:1.21.4from
zyckk4:feat/killaura-ignore-named-mobs

Conversation

@zyckk4

@zyckk4 zyckk4 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

KillAura can currently attack name-tagged mobs kept near the bot. Add killAura ignoreNamedMobs on/off (default: off) to exclude non-player entities with a custom name before evaluating hostile, neutral, or custom targets. Player targeting and existing configurations retain their current behavior.

The filter checks the presence of the optional custom-name metadata, independent of name visibility, and reflects later name additions/removals. Command help, status output, and generated wiki documentation include the setting. This filters direct targets; server-side sword sweeping damage is unaffected.

Closes #333.

Validation

  • Added 14 passing regression cases covering hostile/neutral aggression, custom targets, visibility, empty/removed names, player targeting, defaults, serialization, and the command/status output.
  • Complete local JDK 25 build passed: 93 tests passed, 1 skipped (ConnectIntegTest, Docker unavailable); executable JAR and command documentation generated.
  • Windows qualification: the ordinary gradlew.bat build run hit a temporary-JAR deletion failure in the existing SharedApplicationClassLoaderTest.failedTransformationFallsBackToOriginalBytesAndDisablesTransformers teardown. The successful full run used a local, uncommitted init script setting junit.jupiter.tempdir.cleanup.mode.default=NEVER on test tasks; all test assertions remained enabled. No workaround or unrelated loader changes are included in this PR.
  • git diff --check passed. Live Minecraft-server behavior has not been tested.

@rfresh2
rfresh2 merged commit 92cccb4 into rfresh2:1.21.4 Sep 25, 2026
1 check passed
@rfresh2

rfresh2 commented Sep 25, 2026

Copy link
Copy Markdown
Owner

if you're going to make a pr pls just skip creating the issue next time

@zyckk4
zyckk4 deleted the feat/killaura-ignore-named-mobs branch September 25, 2026 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KillAura: add an option to ignore named mobs

2 participants