Add KillAura option to ignore named mobs - #334
Merged
Merged
Conversation
Owner
|
if you're going to make a pr pls just skip creating the issue next time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KillAura can currently attack name-tagged mobs kept near the bot. Add
killAura ignoreNamedMobs on/off(default: off) to exclude non-player entities with a custom name before evaluating hostile, neutral, or custom targets. Player targeting and existing configurations retain their current behavior.The filter checks the presence of the optional custom-name metadata, independent of name visibility, and reflects later name additions/removals. Command help, status output, and generated wiki documentation include the setting. This filters direct targets; server-side sword sweeping damage is unaffected.
Closes #333.
Validation
ConnectIntegTest, Docker unavailable); executable JAR and command documentation generated.gradlew.bat buildrun hit a temporary-JAR deletion failure in the existingSharedApplicationClassLoaderTest.failedTransformationFallsBackToOriginalBytesAndDisablesTransformersteardown. The successful full run used a local, uncommitted init script settingjunit.jupiter.tempdir.cleanup.mode.default=NEVERon test tasks; all test assertions remained enabled. No workaround or unrelated loader changes are included in this PR.git diff --checkpassed. Live Minecraft-server behavior has not been tested.