Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switch
NSGlassEffectView.stylefrom.clearto.regularon macOS 26+ (1 file, +1 / -1) to match the system input method candidate panel (IMKUIPanel)..clearapplies minimal tinting over the blurred backdrop, so dense underlying text bleeds through more strongly (Scene B) and light-appearance candidate panels over dark backdrops look noticeably dim (Scene D)..regularadds the standard control tint used byIMKUIPanel, keeping candidate text legible across busy documents and high-contrast backgrounds while preserving Liquid Glass translucency.Older macOS versions continue using
NSVisualEffectViewunchanged, and existingstyle/translucency+ transparentback_colorconfiguration behavior is untouched.Visual Comparison
Offscreen
CARenderercomparison across four scenes (DarkAquaandAqua). Both Squirrel rows usetranslucency: true, transparentback_color, single-line layout, and highlight colors matched toIMKUIPanel(controlAccentColor) so only the glass style differs:.clearglass):NSGlassEffectViewwith.clearstyle..regularglass):NSGlassEffectViewwith.regularstyle, matchingIMKUIPanelbackdrop tint and legibility.Verification
git diff --check,swiftlint lint, andSquirreltargetswiftc -typecheckpassed with 0 warnings or violations.CARendererverification acrossDarkAquaandAquaappearances confirmed.regularglass matchesIMKUIPanelbackdrop luminance across all four scenes.