test: add route tests for certificates verify endpoint - #1643
Open
hussnainahmedd wants to merge 2 commits into
Open
hussnainahmedd wants to merge 2 commits into
hussnainahmedd wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the missing colocated test for the certificate verification route handler (
src/app/api/certificates/verify/[id]/route.ts), following the same pattern as the merged email-verification route tests.New file:
src/app/api/certificates/verify/[id]/__tests__/route.test.tsWhat the tests cover
Cache-Control: public, max-age=3600header is set, andverifyCertificateis called with the route param id.verifyCertificatereturnsnull): assertsvalid: falseand the expected error message.CertificateVerificationSchemavalidation: asserts the "Verification response validation failed" error.verifyCertificatethrows: asserts the "Failed to verify certificate" error.The
verifyCertificateservice is mocked (vi.mock); the handler is driven with a plainRequestplus a literal{ params: { id } }context, matching the existing route-test style.Testing notes
pnpm vitest run src/app/api/certificates/verify/[id]/__tests__/route.test.ts— 4/4 tests pass.pnpm run type-check— no new errors (the only 2 errors are pre-existing in unrelated filesSidebarNavigation.tsx/AccessibleModerationTools.tsx).__tests__files per repo config.Closes #1416