Repository navigation
include: mailbox: correct RPMI CPPC request field ordering - #432
Closed
Justin-Nickel-Wu wants to merge 1 commit into
Closed
Justin-Nickel-Wu wants to merge 1 commit into
Justin-Nickel-Wu wants to merge 1 commit into
Conversation
Per the RPMI specification, CPPC_PROBE_REG, CPPC_READ_REG, and CPPC_WRITE_REG require REG_ID in word 0 and HART_ID in word 1. The current request structures have these fields swapped, causing incompatibility with spec-compliant RPMI servers. Swap the fields to match the specification. Signed-off-by: wuliwen <liwen.wu@spacemit.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the field ordering in the RPMI CPPC request structures for CPPC_PROBE_REG, CPPC_READ_REG, and CPPC_WRITE_REG.
According to the RPMI specification, word 0 must contain REG_ID and word 1 must contain HART_ID.
Previously, both OpenSBI and librpmi used the same incorrect field ordering, allowing them to interoperate despite violating the specification. Since librpmi has corrected its implementation, OpenSBI must also update its request structures to restore compatibility.
This change aligns OpenSBI with the RPMI specification and the updated librpmi implementation.
References