Skip to content

datasketches: add build-datasketches.yml for riscv64 wheels - #1642

Open
luhenry wants to merge 1 commit into
mainfrom
datasketches
Open

datasketches: add build-datasketches.yml for riscv64 wheels#1642
luhenry wants to merge 1 commit into
mainfrom
datasketches

Conversation

@luhenry

@luhenry luhenry commented Sep 8, 2026

Copy link
Copy Markdown
Member

Compiles the nanobind/CMake _datasketches extension (probabilistic streaming-algorithm sketches: HLL, KLL, CPC, theta, tuple, quantiles, and friends) that CMake's ExternalProject_Add builds against a fetched checkout of apache/datasketches-cpp at the matching tag, plus the pure-Python datasketches wrapper package. Upstream publishes no riscv64 wheel.

Mirrors upstream's build_wheels.yml.

Differs from upstream

  • Nothing beyond the riscv64 image and the patch below.

Testing

  • tests/ staged into an empty cwd (CIBW_TEST_SOURCES) since the checkout root's own datasketches/ source package would otherwise shadow the installed wheel; same suite tox's changedir = tests runs.

License: OK

Patches

  • 0001-Drop-const-...patch - To upstream. vector_of_kll_sketches's own operator= assigns to its const k_/d_ members; GCC rejects it building the nanobind bindings. Reproduces on any GCC manylinux arch, not riscv64-only.

Built on cp312 equivalent (aarch64 manylinux, local); 37 passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant