build-tantivy: drop the doctest-modules test pass - #1651
Open
luhenry wants to merge 1 commit into
Open
Conversation
Not real coverage: tantivy's compiled classes report __module__ as tantivy.tantivy (the compiled submodule), not tantivy (the wrapper package), so pytest's doctest-modules collector -- whether invoked via --pyargs tantivy or a path-based tantivy target -- finds 0 items against the installed wheel, matching a bare doctest.testmod() call against the actual submodule (confirmed locally against the published 0.25.1 wheel). Exit code 5 (no tests ran) then fails the CIBW_TEST_COMMAND chain. The real pytest suite (tests/, 154 items including the markdown-doc doctests via mktestdocs) is unaffected and is the suite upstream's own CI runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1639, merged before its
cp312/cp313/cp314/cp314tCI legs had finished. All four failed on the same second test step:python -m pytest --pyargs tantivy --doctest-modulesexits 5 (no tests ran).Confirmed locally against the real published 0.25.1 wheel: tantivy's compiled classes report
__module__astantivy.tantivy(the compiled submodule), nottantivy(the wrapper packagefrom .tantivy import *re-exports them into), so pytest's doctest-modules collector finds nothing there whether invoked via--pyargs tantivyor a path-basedtantivytarget - matching what a baredoctest.testmod()call against the real submodule shows. This drops that dead second test step; the real suite (tests/, 154 items, including the markdown-doc doctests viamktestdocs) already covers what upstream's own CI runs and is unaffected.