chore(frontend): sync frontend changes from enterprise - #5792
Conversation
|
🚅 Deployed to the rivet-pr-5792 environment in rivet-frontend
|
|
Review Mostly a clean sync of small, self-contained frontend fixes (multi-select combobox UX, datacenters copy, billing compute row, missing font deps). Nothing structurally concerning. One item worth a second look before merge:
const billedCompute = computeAllowanceUsd != null ? 0 : computeDollars;This variable isn't referenced anywhere else in the file (or the repo, confirmed via grep). Previously it fed into total={Number(totalOverageCents) / 100 + (showCompute ? billedCompute : 0)}That line was simplified to
Nits / smaller notes
🤖 Generated with Claude Code |
| */ | ||
| export function useHasActiveManagedServices(): boolean { | ||
| const dataProvider = useCloudProjectDataProvider(); | ||
| const { data: namespaces } = useInfiniteQuery({ |
There was a problem hiding this comment.
🟠 Medium · Managed-service detection stops after the first namespace page
currentProjectNamespacesQueryOptions() fetches namespaces 100 at a time, but this hook never calls fetchNextPage, so the pool queries cover only the first page. A project whose services pool is in a later namespace returns false; when compute metrics are empty/404, the billing panel then hides the compute row despite managed services being active. Derive this project-wide predicate from a backend/project-level field, or exhaust namespace pagination before checking pools.
| @@ -209,11 +209,12 @@ export const Combobox = <Option extends ComboboxOption>({ | |||
| onValueChange={setSearch} | |||
There was a problem hiding this comment.
🟠 Medium · Multi-select semantics report keyboard focus as selection
cmdk assigns each CommandItem's aria-selected from its keyboard-active item, not from this combobox's isCurrent value, while the new checkbox is aria-hidden. Adding aria-multiselectable therefore tells assistive technology this is a multi-select listbox but reports whichever option has focus as the sole selected option; moving through the list changes the announced selection without toggling anything. Remove this listbox annotation or adapt the option primitive so every item exposes its actual selected state independently of cmdk's active-item state.
+Nbadge.@fontsource/ibm-plex-*fonts that the component theme already imports.