Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
scheduleCronaction takes aSerializableCronAction, where a session action carriescwdat the top level. The action object was passed to agent-os-core with a plain type cast. The core cron manager starts the session withcreateSession(action.agentType, action.options), so thecwdwas dropped and scheduled sessions ran in the default directory.listCronJobsreads the value back fromaction.options?.cwd, so the job listing also showed nocwd.scheduleCronnow converts the action into the coreCronActionshape and putscwdintooptions. Exec actions are passed through field by field.cron.test.tsto check that the action reaching the VM carriesoptions.cwdand thatlistCronJobsreturns the samecwd.Type of change
How Has This Been Tested?
pnpm vitest run src/agent-os/actor/cron.test.tsinrivetkit-typescript/packages/rivetkit. Onmainthe session test fails because the VM receives{ type: "session", agentType, prompt, cwd }with nooptions. With this change both tests pass.biome checkis clean on the changed files.tsc --noEmitfor the package reports no errors in the changed files.vitest run srcfor the package: the only failures are the same 3 that fail onmainin my local setup (inline-websocket-adapter.test.tsandruntime.test.tsfail to load, and oneworkflow/driver.test.tscase), so this change adds no new failures.Checklist: