Repository navigation
CLAUDE.md: how a PR gets merged, where a new preference goes, checking behaviour offline - #38
Merged
Merged
Conversation
…s; checking behaviour offline - main takes only a branch that is up to date with it and green on both CI jobs: merge origin/main in (a merge commit), test, push, wait for CI on that head, then merge the PR with a merge commit. - A new preference goes in config's PREFERENCE_KEYS and preference_values, defaults/preferences.conf, the README table and its key count, and tests/test_config.py; the tests catch all but the README. - With Yahoo and Sharesight out of reach, behaviour is checked against the offline fixtures, and a refactor by comparing old and new output. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
…0z2q Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three notes for future sessions, learned while working on #37. Only
CLAUDE.mdchanges.maintakes only a branch that is up to date with it and green on both CI jobs. Mergeorigin/maininto the work branch (a merge commit, never a rebase), run the tests, push, wait for CI on that head, then merge the PR with a merge commit.PREFERENCE_KEYSandpreference_values(lib/config.py),defaults/preferences.conf, the README's preferences table and its key count, andDEFAULTSplus the key count intests/test_config.py. The tests catch all but the README.tests/common.py. A refactor is checked by comparing old and new output.The branch also carries a merge of
main(#37's merge commit), which brings it up to date and changes no files.🤖 Generated with Claude Code
https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
Generated by Claude Code