Repository navigation
settings.conf (was preferences.conf) and "settings" throughout, check_config permission check, docs say push mode - #43
Merged
Conversation
…, neater comments) An old preferences.conf in the data dir is renamed to settings.conf at start, so no setting is lost. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
…and docs; check_config warns when finbot.env is not 600 root:root; check_config tidied config.prefs is config.settings, Prefs is Settings, read_preferences is read_settings and so on. The legacy file name preferences.conf stays only where an upgrade renames it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
… defaults/finbot.env) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
preferences.confis nowsettings.confdefaults/settings.conf, tidied: shorter lines, neater comments, same keys and defaults), the CI check,finbot.service,compose.yamland every doc.<DATA_DIR>/preferences.confis renamed tosettings.conf(said on stderr), unless asettings.confis already there; if the rename fails it warns. Without this an upgrade would have quietly ignored existing settings. Tests cover it."settings", not "preferences"
config.prefsisconfig.settings,PrefsisSettings,read_preferencesisread_settings,PREFERENCE_KEYSisSETTING_KEYS, ...), messages, tests, docs andCLAUDE.md. The old file namepreferences.confstays only where the upgrade renames it.util/check_config.pyfinbot.envis not mode 600 owned byroot:root, naming thechmod/chownfix. A warning, not an error, so Docker's bind-mounted env files (often owned by the host user) still start. Install docs andfinbot.servicenow say600 root:root.Docs
README.md,compose.yamlanddefaults/finbot.env(code comments, tests and one startup warning still say "HTTP mode").Testing
.venv/bin/python -m unittest discover -s tests -b), after mergingorigin/main(the merge of /compare takes up to 8 tickers #42).🤖 Generated with Claude Code
https://claude.ai/code/session_01JVEkZofdPjQ4jtXFKipeUX
Generated by Claude Code