Skip to content

ci: stop building Node.js 20 binaries - #59

Merged
arv merged 3 commits into
mainfrom
arv/fix-next-batch-node20
Oct 19, 2026
Merged

arv merged 3 commits into
mainfrom
arv/fix-next-batch-node20

Conversation

@arv

@arv arv commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

The v1.1.7 release workflow failed in the prebuild jobs, so nothing was published (the publish job was skipped). The cause is StatementIterator::NextBatch (#57), which uses v8::LocalVector. That API only exists from NODE_MODULE_VERSION 127 (Node 22) on, and NODE_BUILD_CMD_LEGACY also built binaries for Node 20.

Node 20 is past end of life and isn't in engines (22.x || 24.x), and mono-internal only needs Node 22+. So this drops -t 20.0.0 from the prebuilds instead of guarding the code; an earlier commit here added a guard, which is now reverted. The Node 20 container images stay, because they only host the build tool.

Local results:

  • Node 22, 24 and 26: build, and 366 tests pass.
  • Node 23: builds, and 365 tests pass (one is pending).

PR CI only tests Node 22, 24 and 26, which is why #57's CI didn't catch the Node 20 failure.

Copilot AI lite review requested due to automatic review settings October 19, 2026 13:23
@github-actions
github-actions Bot requested a review from tantaman October 19, 2026 13:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The compatibility change is scoped and has no unresolved review issues.

No open issues 🎉

What changed in this PR

Updates nextBatch() to compile on Node versions without v8::LocalVector.

Changes:

  • Uses LocalVector for Node module versions 127+.
  • Uses std::vector as a fallback for older versions.
File Description
src/​objects/​statement-iterator.cpp Adds the Node-version-compatible value container fallback.

Review effort: Lite

@arv arv changed the title fix: build nextBatch() on Node 20 and 23 ci: stop building Node.js 20 binaries Oct 19, 2026
@arv
arv added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit 05177f6 Oct 19, 2026
18 checks passed
@arv
arv deleted the arv/fix-next-batch-node20 branch October 19, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants