Repository navigation
ci: stop building Node.js 20 binaries - #59
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The compatibility change is scoped and has no unresolved review issues.
No open issues 🎉
What changed in this PR
Updates nextBatch() to compile on Node versions without v8::LocalVector.
Changes:
- Uses
LocalVectorfor Node module versions 127+. - Uses
std::vectoras a fallback for older versions.
| File | Description |
|---|---|
src/objects/statement-iterator.cpp |
Adds the Node-version-compatible value container fallback. |
Review effort: Lite
…lVector" This reverts commit b73530e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.1.7 release workflow failed in the prebuild jobs, so nothing was published (the publish job was skipped). The cause is
StatementIterator::NextBatch(#57), which usesv8::LocalVector. That API only exists from NODE_MODULE_VERSION 127 (Node 22) on, andNODE_BUILD_CMD_LEGACYalso built binaries for Node 20.Node 20 is past end of life and isn't in
engines(22.x || 24.x), and mono-internal only needs Node 22+. So this drops-t 20.0.0from the prebuilds instead of guarding the code; an earlier commit here added a guard, which is now reverted. The Node 20 container images stay, because they only host the build tool.Local results:
PR CI only tests Node 22, 24 and 26, which is why #57's CI didn't catch the Node 20 failure.