Skip to content

Support variable and function references - #780

Open
georgejecook wants to merge 2 commits into
feat/find-references-pluginfrom
support-variable-and-function-references
Open

georgejecook wants to merge 2 commits into
feat/find-references-pluginfrom
support-variable-and-function-references

Conversation

@georgejecook

Copy link
Copy Markdown
Contributor

No description provided.

@TwitchBronBron
TwitchBronBron changed the base branch from master to feat/find-references-plugin March 9, 2023 12:13
@TwitchBronBron

Copy link
Copy Markdown
Member

Why'd ya close this?

@georgejecook

georgejecook commented May 3, 2025

Copy link
Copy Markdown
Contributor Author

Why'd ya close this?

because I just installed GitLens, and my OCD triggered, and I had to go and close things because there was too much stuff, and this was years old. sorry if that was wrong.

@TwitchBronBron

Copy link
Copy Markdown
Member

Haha. I do intend on eventually reviewing and fixing up and merging it. Just been a low priority against v1 and lsp and stuff. I'll reopen it for now, and try to review in the next month or two.

@TwitchBronBron TwitchBronBron reopened this May 3, 2025
@georgejecook

Copy link
Copy Markdown
Contributor Author

I understand; though this makes me think I should stay away from GitLens.. who knows what I'll do next!? 🤪

@georgejecook
georgejecook marked this pull request as ready for review September 18, 2026 08:44
…o support-variable-and-function-references
@georgejecook

Copy link
Copy Markdown
Contributor Author

Updated this branch with its current target, feat/find-references-plugin, at 69968574dddfdc5e5fcebd1ff4cd3ebed9eb2614. This PR is still not ready to merge.

  • CI run fails during macOS setup: Unable to find Node version 14.18.1 for platform darwin and architecture arm64. Matrix fail-fast cancels Linux and Windows before test completion. No CI runtime or runner policy was changed.
  • Local lint reports the committed describe.only and it.only markers in ReferencesProcessor.spec.ts.
  • Local TypeScript 4.7.2 checking reports srcPath and range on unknown in the unchanged LanguageServer.ts lines 1255–1256.
  • An isolated diagnostic run of the existing ReferencesProcessor spec, using transpile-only because type checking failed, reports 0 passing and 1 failing. The assertion at line 178 expects local-variable fixture ranges while the fixture contains function references. This is not a passing test result.

Source inspection also shows unfinished behavior: namespaceFunctionCall has no dispatch case; class references always return an empty list; and the dotted-reference loop compares the original expression rather than each candidate. Completing that behavior and repairing the old feature branch CI need separate implementation decisions. Only the base merge was pushed; the feature code and assertions were left intact. No packages were published.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants