Skip to content

docs: AGENTS.md allineato a CI su master e packaging Electron - #36

Merged
ronzim merged 1 commit into
masterfrom
docs/agents-ci
Oct 14, 2026
Merged

ronzim merged 1 commit into
masterfrom
docs/agents-ci

Conversation

@ronzim

@ronzim ronzim commented Oct 14, 2026

Copy link
Copy Markdown
Owner

🤖 Generated with Claude Code

https://claude.ai/code/session_01CecUKcJiSVnehcZEiXLgtk

Copilot AI balanced review requested due to automatic review settings October 14, 2026 06:51
@ronzim
ronzim merged commit 2a8a49f into master Oct 14, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

It is a documentation-only change whose CI and packaging claims were all verified accurate against ci.yml, publish.yml, package.json, and electron.vite.config.ts.

0 open findings

What changed in this PR

This PR updates AGENTS.md (the repository's agent/contributor documentation) to align the "Deploy" and "Convenzioni" sections with the current state of CI on master and the Electron packaging setup. It removes a now-obsolete TODO about branch alignment and documents the packaging rationale so that issue #26 (electron-builder failing because it wiped devDependencies) is not reintroduced.

Changes:

  • Deploy section corrected to reflect the actual CI: Node 20/22 (not 18/20/22), triggers on push and PR to master, typecheck runs after the core build, and Electron packaging uses --publish never.
  • Added a packaging convention explaining that the packaged app ships without node_modules, mappit-core is bundled from source via the alias in electron.vite.config.ts, and npmRebuild: false prevents electron-builder from wiping devDependencies.
File Description
AGENTS.md Aligns the Deploy section with the current master CI workflow and adds a packaging convention documenting the npmRebuild: false rationale.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants