Skip to content

[core] deprecate implementation detail zip headers since there is RZip public interface - #23271

Open
ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:zipdepr
Open

[core] deprecate implementation detail zip headers since there is RZip public interface#23271
ferdymercury wants to merge 4 commits into
root-project:masterfrom
ferdymercury:zipdepr

Conversation

@ferdymercury

@ferdymercury ferdymercury commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

This Pull request:

Changes or fixes:

This is necessary step before #23270

At the moment, the headers are just copy-pasted where used. Once they are fully removed in 6.46, one can recreate them in a private folder. I wanted to prevent now creating them with the same name in two different folders which calls for problems.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown

Test Results

    23 files      23 suites   3d 18h 7m 48s ⏱️
 3 883 tests  3 883 ✅ 0 💤 0 ❌
79 003 runs  79 003 ✅ 0 💤 0 ❌

Results for commit c2679e7.

♻️ This comment has been updated with latest results.

@ferdymercury
ferdymercury marked this pull request as ready for review September 6, 2026 11:08
@jblomer jblomer self-assigned this Sep 6, 2026
@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Sep 8, 2026
Comment thread core/zip/src/RZip.cxx

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is fine to deprecate those headers. Thanks.

Comment thread builtins/zip/ZInflate.c
Comment thread builtins/zip/ZInflate.c
Comment thread core/lz4/src/ZipLZ4.cxx
Comment thread core/lzma/src/ZipLZMA.c
Comment thread core/zip/src/RZip.cxx
Comment thread core/zip/src/RZip.cxx Outdated
Comment thread core/zip/src/RZip.cxx
Comment thread core/zstd/src/ZipZSTD.cxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants