[core] deprecate implementation detail zip headers since there is RZip public interface - #23271
Open
ferdymercury wants to merge 4 commits into
Open
[core] deprecate implementation detail zip headers since there is RZip public interface#23271ferdymercury wants to merge 4 commits into
ferdymercury wants to merge 4 commits into
Conversation
ferdymercury
force-pushed
the
zipdepr
branch
from
September 5, 2026 22:34
66c6426 to
9cc9082
Compare
Test Results 23 files 23 suites 3d 18h 7m 48s ⏱️ Results for commit c2679e7. ♻️ This comment has been updated with latest results. |
ferdymercury
marked this pull request as ready for review
September 6, 2026 11:08
ferdymercury
force-pushed
the
zipdepr
branch
from
September 7, 2026 18:24
3ab4509 to
80d919d
Compare
pcanal
reviewed
Sep 8, 2026
pcanal
approved these changes
Sep 8, 2026
pcanal
left a comment
Member
There was a problem hiding this comment.
I think it is fine to deprecate those headers. Thanks.
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
ferdymercury
commented
Sep 8, 2026
…p public interface
as suggested by pcanal
ferdymercury
force-pushed
the
zipdepr
branch
from
September 8, 2026 21:28
8b0943e to
c2679e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This is necessary step before #23270
At the moment, the headers are just copy-pasted where used. Once they are fully removed in 6.46, one can recreate them in a private folder. I wanted to prevent now creating them with the same name in two different folders which calls for problems.