[tmva][sofie] Adds the missing ONNX operators Asinh, Acosh, and Atanh to TMVA SOFIE. - #23299
Merged
guitargeek merged 1 commit intoSep 8, 2026
Conversation
Signed-off-by: Sainava <sainava.modak@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request
Adds the missing ONNX operators
Asinh,Acosh, andAtanhto TMVA SOFIE.Changes & Fixes
tmva/sofie/inc/TMVA/ROperator_BasicUnary.hxx: AddedAsinh,Acosh, andAtanhto theEBasicUnaryOperatorenum and their correspondingUnaryOpTraitsspecializations, following the same pattern already used forSin,Cos, andAtan. A comment notes thatAcoshandAtanhhave restricted domains (x >= 1 and |x| < 1 respectively) and rely onstd::acoshandstd::atanhreturning NaN outside those ranges.tmva/sofie_parsers/src/ParseBasicUnary.cxx&tmva/sofie_parsers/src/RModelParser_ONNX.cxx: Added the corresponding parser lambdas and operator registrations, matching the existingParseAtanpattern exactly.tmva/sofie/test/generate_input_models.py&tmva/sofie/test/TestCustomModelsFromONNX.cxx: Added tests for all three operators, utilizing domain appropriate input values forAcoshandAtanh.Checklist
This PR fixes #23275
@guitargeek, following up on our conversation, this PR implements Asinh, Acosh, and Atanh as outlined in the issue. Please let me know if this looks good to you or if you need any adjustments.Thanks!