[Python] Use value_type and not string matching to pythonize STL vector - #23324
Open
guitargeek wants to merge 1 commit into
Open
[Python] Use value_type and not string matching to pythonize STL vector#23324guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Instead of matching numpy-compatible element types by string manipulation on the class name, use the `value_type` typedef that cppyy exposes on std::vector proxies. This decouples the pythonization from how cppyy happens to spell template instantiation names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of matching numpy-compatible element types by string manipulation on the class name, use the
value_typetypedef that cppyy exposes on std::vector proxies. This decouples the pythonization from how cppyy happens to spell template instantiation names.