Skip to content

Add cmath for fabs() - #153

Merged
christophfroehlich merged 3 commits into
mainfrom
cmath
Nov 2, 2026
Merged

christophfroehlich merged 3 commits into
mainfrom
cmath

Conversation

@christophfroehlich

@christophfroehlich christophfroehlich commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Description

/workspaces/ros2_rolling_ws/src/topic_based_hardware_interfaces/joint_state_topic_hardware_interface/test/rrr/jtc_client_position.cpp:83:9: error: ‘fabs’ was not declared in this scope; did you mean ‘uabs’?
   83 |     if (fabs(feedback->actual.positions[0] - desired_goals.at(ct_goals_reached)) <= 0.05)
      |         ^~~~
      |         uabs

Is this user-facing behavior change?

no

Did you use Generative AI?

yes

Additional information

Rolling jobs fail because of ros-tooling/topic_tools#157

@github-project-automation github-project-automation Bot moved this to Ready for review in Review triage Nov 1, 2026
@christophfroehlich christophfroehlich moved this from Ready for review to Needs 2nd review in Review triage Nov 1, 2026
@christophfroehlich
christophfroehlich merged commit 4f66793 into main Nov 2, 2026
36 of 44 checks passed
@christophfroehlich
christophfroehlich deleted the cmath branch November 2, 2026 10:40
@github-project-automation github-project-automation Bot moved this from Needs 2nd review to Done in Review triage Nov 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants