Repository navigation
docs: refresh the 1.44 screenshots and the prose they carry - #142
Merged
Merged
Conversation
Brings the usage guides in line with what 1.44 actually renders. Images go from 208 to 218: 13 new, 3 removed, the rest recaptured against a stack built from the v1.44.0 tag. Images The issues content moves to its own page with its images beside it. Three images are deleted rather than reshot, because the UI they documented no longer exists: the alert banner that announced detected issues, the duplicate banner, and the three-dot menu entry for the conflicts dialog. All three were consolidated into the actions center in 1.44, which the remaining images now show. Eleven images under history/issues had been moved there from history/events without being retaken, so they still showed 1.41.4.dev and 1.42.1 builds, a "Combined filters" control that no longer exists, and transient sync banners. A rename is not a recapture, and no gate can see the difference: every check passed the whole time. Dialogs are cropped to their own bounds rather than shot as full viewports, which is what the overlay convention asks for and what the old images in this set were ignoring. Prose Corrections found by putting the screen next to the code rather than reading the changelog: - The conflicts filter is the shared pill bar with a Chain pill and a Date pill; the "combined filters" it replaced is gone. - The two conflict settings default to 100 and 15 minutes, not 20 and 60. The old numbers matched the frontend's constants, which disagree with the backend's. Those settings are titled differently on the general settings page, which the page now says. - The address alias priority list is not opt-in, and its default order is the one the backend ships. - GNS names, the notification tab order, the browser-only help entries and the accounting rules pills are restated to match the app. - Recommended asset movement matches are marked only when a candidate stands out, so that is described as conditional. The empty state and its Widen search button are documented for the first time. The issue category table gains an action column, premium markers, and a note that ignoring items changes a row's action rather than hiding it. CI A new check that the links the app makes into these docs resolve, plus tightening of the image and anchor gates. None of them can detect a stale image; that gap is still open.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the usage guides in line with what 1.44 actually renders. Images go from 208 to 218: 13 new, 3 removed, the rest recaptured against a stack built from the
v1.44.0tag.Three images are deleted, not reshot
The UI they documented no longer exists. Neither the banner headline nor the duplicate-count strings survive in the app's
en.json, and the three-dot menu no longer offersCheck internal tx conflicts:internal_tx_conflicts_banner.webpduplicate_custom.webpinternal_tx_conflicts_menu.webpAll three were consolidated into the actions center in 1.44, which the remaining images now show. The three passages describing them are rewritten.
A rename is not a recapture
Eleven images under
history/issues/had been moved there fromhistory/events/without being retaken. They still showed 1.41.4.dev and 1.42.1 builds, aCombined filterscontrol that no longer exists, and transient sync banners baked into frame.Worth flagging for the review: every gate passed the whole time. Reference resolution, orphans and placement were all green while three images documented deleted features. Nothing detects a stale image today.
Dialogs are now cropped to their own bounds rather than shot as full viewports, per the overlay convention.
Prose corrections
Found by putting the screen next to the code, not by reading the changelog:
Chainpill and aDatepill). The "combined filters" it replaced is gone.Internal transactions to repull,Conflict repull frequency), which the page now says.Widen searchbutton are documented for the first time.The issue category table gains an action column, premium markers, and a note that ignoring items changes a row's action rather than hiding it.
CI
A new check that the links the app makes into these docs resolve, plus tightening of the image and anchor gates.
Two app defects found while capturing (not fixed here)
Both verified against
v1.44.0and present onbugfixes:The Pending tab returns every unfixed conflict.
rotkehlchen/db/filtering.pyhasif failed:over afailed: bool = Falseparameter, sofailed=falseis indistinguishable from "not supplied" and no filter is applied. Confirmed at the API boundary:?failed=false&fixed=falsereturns 11 where it should return 0, while?failed=trueand?fixed=trueare both correct.Frontend and backend disagree on both conflict-setting defaults, and the reset control writes the frontend value — so "reset to default" sets a non-default.
internal_txs_to_repullStill open
history/eventsalone holds 22, and it is the same area 1.44 churned hardest. Given roughly a quarter of what was inspected here documented removed features, that backlog likely hides more of the same.