Skip to content

chore: align VS Code configuration with Rstack - #50

Merged
chenjiahan merged 1 commit into
mainfrom
fix-rstack-config
Sep 4, 2026
Merged

chore: align VS Code configuration with Rstack#50
chenjiahan merged 1 commit into
mainfrom
fix-rstack-config

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

VS Code does not use Rstack as the repository-wide default formatter. Align the shared editor settings with rsbuild-plugin-template. Recommend the Rstack extension alongside the formatter setting.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T13:37:12.912658Z 787d9b6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 787d9b68b8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .vscode/settings.json
}
},
"search.useIgnoreFiles": true,
"editor.defaultFormatter": "rstack.rstack"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Limit the default formatter to supported languages

When a contributor has a formatter for an unsupported language installed, this workspace-wide setting prevents it from acting as the default. For example, the repository contains .agents/skills/diagnosing-bugs/scripts/hitl-loop.template.sh, but Rstack registers formatting only for the 24 language IDs in packages/vscode/src/stacks/fmt/index.ts and does not include shellscript; VS Code therefore selects rstack.rstack and reports that it cannot format the file instead of using the available shell formatter. Scope this setting to the language IDs supported by Rstack.

Useful? React with 👍 / 👎.

@chenjiahan
chenjiahan merged commit 7d0b829 into main Sep 4, 2026
3 checks passed
@chenjiahan
chenjiahan deleted the fix-rstack-config branch September 4, 2026 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant