Skip to content

Keep the dash when joining separated linker flags #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OskarEichler wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Keep the dash when joining separated linker flags #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0caf8d6
Keep the dash when joining separated linker flags
OskarEichler Aug 28, 2026
d84a0d3
Add regression coverage for keep the dash when joining separated link…
OskarEichler Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/pkg-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,7 +639,7 @@ def split_lib_flags(libs_command_line)
all_flags = {}
flags = []
in_option = false
libs_command_line.gsub(/-([Ll]) /, "\\1").split.each do |arg|
libs_command_line.gsub(/(-[Ll])\s+/, "\\1").split.each do |arg|
if in_option
flags << arg
in_option = false
Expand Down
5 changes: 5 additions & 0 deletions test/test-pkg-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,11 @@ def split_lib_flags(libs_command_line)
@glib.__send__(:split_lib_flags, libs_command_line)
end

def test_split_separated_lib_options
assert_equal(["-L/tmp/lib", "-lexample"],
split_lib_flags("-L /tmp/lib -l example"))
end

def test_split_libs
assert_equal([
"-L/usr/local/Cellar/gtk+3/3.24.10/lib",
Expand Down