Skip to content

Add library paths to $LDFLAGS on mswin too #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Largo wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −5
Draft

Add library paths to $LDFLAGS on mswin too #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/pkg-config.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,11 +120,11 @@ def have_package(pkg, major=nil, minor=0, micro=0)
Shellwords.shellwords(libraries))
dldflags = dldflags.map {|s| /\s/ =~ s ? "\"#{s}\"" : s }.join(" ")
$libs += " " + libraries
if /mswin/ =~ RUBY_PLATFORM
$DLDFLAGS += " " + dldflags
else
$LDFLAGS += " " + dldflags
end
# mkmf uses $LDFLAGS for both have_func()/try_link() and the
# final link (mswin's Makefile puts $(ldflags) into DLDFLAGS
# too), so /libpath: must go there on mswin as well. With
# $DLDFLAGS only, every link check against the package fails.
$LDFLAGS += " " + dldflags
$CFLAGS += " " + cflags_only_other(pkg)
if defined?($CXXFLAGS)
$CXXFLAGS += " " + cflags_only_other(pkg)
Expand Down