Skip to content

Honor exception: false for complex conversion #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tompng merged 2 commits into from
Sep 12, 2026
+7 −8
Merged

Honor exception: false for complex conversion #549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a8c1ddf
Honor exception false for complex conversion
OskarEichler Aug 29, 2026
389cd58
Add test for BigDecimal(complex, exception: false)
tompng Sep 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ext/bigdecimal/bigdecimal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2898,7 +2898,7 @@ rb_convert_to_BigDecimal(VALUE val, size_t digs, int raise_exception)
else if (RB_TYPE_P(val, T_COMPLEX)) {
VALUE im = rb_complex_imag(val);
if (!is_zero(im)) {
/* TODO: handle raise_exception */
if (!raise_exception) return Qnil;
rb_raise(rb_eArgError,
"Unable to make a BigDecimal from non-zero imaginary number");
}
Expand Down
13 changes: 6 additions & 7 deletions test/bigdecimal/test_bigdecimal.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,13 +293,12 @@ def test_BigDecimal_with_exception_keyword
assert_nothing_raised(ArgumentError) {
assert_equal(nil, BigDecimal(4.2, Float::DIG + 2, exception: false))
}
# TODO: support conversion from complex
# assert_raise(RangeError) {
# BigDecimal(1i, exception: true)
# }
# assert_nothing_raised(RangeError) {
# assert_equal(nil, BigDecimal(1i, exception: false))
# }
assert_raise(ArgumentError) {
BigDecimal(1i, exception: true)
}
assert_nothing_raised(ArgumentError) {
assert_equal(nil, BigDecimal(1i, exception: false))
}
assert_raise_with_message(TypeError, "can't convert nil into BigDecimal") {
BigDecimal(nil, exception: true)
}
Expand Down