Repository navigation
Error format adjustments - #4320
Merged
Merged
Conversation
When an error is very far into a line, we were previously displaying the whole context line above it and then padding out spaces before the error message. For pathological cases, this ends up being really bad. Instead we now display errors under a window of context.
Instead of checking each line individually, sort all of the errors and do a single walk over the source to figure out if it is valid UTF-8 to determine how to format the errors.
Do not hard-code the potential values for gutters, instead build them on the fly based on what is actually found in the range of the errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed ups, windowing to make sure we don't give too much context, and checking for UTF-8 in one pass. Error formatting appears to have gotten about 2x faster and is no longer quadratic with respect to input. Fixes #4304.