Return failed job responses for development API generator errors - #589
Open
betacatsling wants to merge 1 commit into
Open
Return failed job responses for development API generator errors#589betacatsling wants to merge 1 commit into
betacatsling wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generator exceptions in the development API currently become
KeyError: 'output'because the aggregation loops assume every item is a successful result. Preserve the error item and return aFAILEDjob response for/runsync,/status, and/stream. The queued job is removed after a failed status/stream request.The regression uses real sync and async generator handlers through an in-memory ASGI client, with failures both before and after a yielded result. All 12 cases fail on the unchanged base and pass with the fix. Local validation: 644 unit tests passed, including the repository's coverage check; cloud E2E and performance tests were excluded. Black checked the new test and changed production ranges;
git diff --checkpassed. Proxy environment variables were cleared for the offline unit suite.This is the development-API error aggregation path from #306; #587 changes error delivery in the separate production
handle_jobpath.AI assistance was used for implementation and local verification. No RunPod resources were provisioned.
Fixes #306.