Apply configured retries to HTTPS endpoint requests - #591
Open
betacatsling wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RunPodClientmounts its retry adapter only for HTTP, while the normal RunPod endpoint URL uses HTTPS. A rate-limited HTTPS GET therefore fails immediately instead of using the configured retry policy.Mount that policy for HTTPS as well. The regression runs real local HTTP and HTTPS servers that return 429 once, then 200. It verifies both responses are requested and the client succeeds, with TLS certificate verification enabled. On the unchanged base, HTTPS fails while the HTTP control passes.
Local validation: 634 unit tests passed, including the repository's coverage check; cloud E2E and performance tests were excluded. Black checked the new test and changed production line, and
git diff --checkpassed. No RunPod resources or live provider calls were used.AI assistance was used for implementation and local verification.
Fixes #590.