Repository navigation
Spsc::peek: Fix atomic ordering bug - #703
Merged
Merged
Conversation
sgued
force-pushed
the
spsc-unsoundness
branch
from
November 11, 2026 10:01
df060d9 to
ec4f70d
Compare
newAM
previously approved these changes
Nov 11, 2026
newAM
left a comment
newAM
left a comment
Member
There was a problem hiding this comment.
Minor typo in the commit message, "commited" should be "committed".
sgued
force-pushed
the
spsc-unsoundness
branch
from
November 11, 2026 21:46
ec4f70d to
2c1f14b
Compare
sgued
enabled auto-merge
November 11, 2026 21:47
The written data is then committed with a Release write to "tail". Tail needs to be loaded with Acquire ordering then to ensure proper concurrency.
sgued
force-pushed
the
spsc-unsoundness
branch
from
November 11, 2026 21:49
2c1f14b to
5fd9d2c
Compare
newAM
approved these changes
Nov 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The written data is then commited with a Release write to "tail". Tail needs to be loaded with Acquire ordering then to ensure proper concurrency.