Skip to content

Take consuming key in position_{min,max,minmax}_by_key() - #1137

Merged
phimuemue merged 1 commit into
rust-itertools:masterfrom
ronnodas:position-min-max-consume
Oct 21, 2026
Merged

phimuemue merged 1 commit into
rust-itertools:masterfrom
ronnodas:position-min-max-consume

Conversation

@ronnodas

Copy link
Copy Markdown
Contributor

Fixes #1135. This is a breaking change.

@codecov

codecov Bot commented Oct 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.78%. Comparing base (6814180) to head (0c35c2f).
⚠️ Report is 224 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1137      +/-   ##
==========================================
- Coverage   94.38%   93.78%   -0.61%     
==========================================
  Files          48       52       +4     
  Lines        6665     6484     -181     
==========================================
- Hits         6291     6081     -210     
- Misses        374      403      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phimuemue phimuemue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good catch

@phimuemue
phimuemue added this pull request to the merge queue Oct 21, 2026
Merged via the queue into rust-itertools:master with commit fb3d996 Oct 21, 2026
8 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

position_{min,max,minmax}_by_key() could take a key function that consumes the items

2 participants